chore: Fix user permissions #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 151161f.
Eric-Warehime
requested review from
aljo242,
technicallyty and
wesl-ee
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
+ Coverage 56.53% 56.54% +0.01%
==========================================
Files 257 257
Lines 13505 13505
==========================================
+ Hits 7635 7637 +2
+ Misses 5133 5131 -2
Partials 737 737 ☔ View full report in Codecov by Sentry. |
technicallyty
approved these changes
Aug 27, 2024
wesl-ee
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a new user in this way ends up with issues when using an entrypoint command since no entries exist in the corresponding etc/ files.
I tried setting the
nobodyuser which is built into distroless images, but then mounting files in to use as a config becomes an issue. It seems pretty low stakes to give users root inside the distroless container, so I'm just reverting for now.